phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-841) Upserting into tenant-specific view with no where clause fails with an NPE
Date Fri, 14 Mar 2014 18:46:43 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935435#comment-13935435
] 

ASF GitHub Bot commented on PHOENIX-841:
----------------------------------------

Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/16#discussion_r10621363
  
    --- Diff: phoenix-core/src/test/java/org/apache/phoenix/end2end/TenantSpecificTablesDMLTest.java
---
    @@ -384,4 +384,17 @@ public void testTenantTableCannotBeUsedInStatementsInNonMultitenantConnections()
                 conn.close();
             }
         }
    +    
    +	@Test
    +	public void testUpsertValuesUsingViewWithNoWhereClause() throws Exception {
    +		Connection conn = nextConnection(PHOENIX_JDBC_TENANT_SPECIFIC_URL);
    +		conn.setAutoCommit(true);
    +		conn.createStatement().executeUpdate("upsert into " + TENANT_TABLE_NAME_NO_TENANT_TYPE_ID
+ " (id) values (0)");
    +		
    +        ResultSet rs = conn.createStatement().executeQuery("select id from " + TENANT_TABLE_NAME_NO_TENANT_TYPE_ID);
    +        assertTrue(rs.next());
    --- End diff --
    
    @jtaylor-sfdc, with the null check in UpsertCompiler upsert no longer NPEs.  This test
is now failing at this line, meaning this select does not return the expected single row.
 Haven't had time to debug further.


> Upserting into tenant-specific view with no where clause fails with an NPE
> --------------------------------------------------------------------------
>
>                 Key: PHOENIX-841
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-841
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Eli Levine
>             Fix For: 3.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message