phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-905) Wrong calculation of maxSetBit in ValueBitSet#or(ImmutableBytesWritable)
Date Tue, 01 Apr 2014 03:04:16 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956048#comment-13956048
] 

ASF GitHub Bot commented on PHOENIX-905:
----------------------------------------

Github user maryannxue commented on the pull request:

    https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39166452
  
    It would not work correctly.
    
    -            maxSetBit = Math.max(maxSetBit, nLongs * Bytes.SIZEOF_LONG - 1);
    +            maxSetBit = Math.max(maxSetBit, nLongs * BITS_PER_LONG - 1);
    
    maxSetBit would be smaller than it should be. Thus, toBytes() would not serialize all
necessary bits.


> Wrong calculation of maxSetBit in ValueBitSet#or(ImmutableBytesWritable)
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-905
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-905
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 4.0.0, 5.0.0
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>             Fix For: 3.0.0, 4.0.0, 5.0.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message