phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-927) Support derived tables in joins
Date Sat, 12 Apr 2014 00:26:17 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967288#comment-13967288
] 

ASF GitHub Bot commented on PHOENIX-927:
----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/28#discussion_r11556890
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java ---
    @@ -80,7 +80,7 @@ public QueryPlan optimize(QueryPlan dataPlan, PhoenixStatement statement,
List<?
             // TODO: the recompile for the index tables could skip the normalize step
             SelectStatement select = (SelectStatement)dataPlan.getStatement();
             // TODO: consider not even compiling index plans if we have a point lookup
    -        if (!useIndexes || select.isJoin()) {
    +        if (!useIndexes || select.isJoin() || dataPlan.getContext().getResolver().getTables().size()
> 1) {
    --- End diff --
    
    Minor, but would be nice to cover this with something like an isDerivedTable or some such
method.


> Support derived tables in joins
> -------------------------------
>
>                 Key: PHOENIX-927
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-927
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>              Labels: enhancement
>             Fix For: 3.0.0, 4.0.0, 5.0.0
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Support grammar like:
> SELECT a.col1, b.col2, c.col3 FROM 
> (SELECT rk, col1 FROM table1 WHERE col1 LIKE 'foo%' AND col300 IS NULL) AS a 
> JOIN (SELECT rk, col2 FROM table2 WHERE col2 LIKE 'bar%') AS b ON a.rk=b.rk 
> JOIN (SELECT rk, col3 FROM table3 ) AS c ON a.rk=c.rk;



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message