phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsjohn <...@git.apache.org>
Subject [GitHub] incubator-phoenix pull request: Add functions FIRST_VALUE and LAST...
Date Fri, 23 May 2014 06:28:29 GMT
Github user anoopsjohn commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/30#discussion_r12987056
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/FirstLastValueDataContainer.java
---
    @@ -0,0 +1,123 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.util;
    +
    +/**
    + * Container for data transfer between server and client aggregation (FIRST|LAST|NTH)_VALUE
functions
    + *
    + */
    +public class FirstLastValueDataContainer {
    +
    +	protected boolean useCompression;
    +	protected byte[] order;
    +	protected byte[] value;
    +	protected boolean isAscending;
    +
    +	public void setBytesMessage(byte[] msg) {
    --- End diff --
    
    Can you uniform the method names for this setter (and getter also) both both the DataContainer
classes?  setPayload in one place and setBytesMessage in another.  May be go with setPayload
(?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message