phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-896) Improve cmdline parsing of psql (PhoenixRuntime)
Date Tue, 03 Jun 2014 19:13:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017016#comment-14017016
] 

Hudson commented on PHOENIX-896:
--------------------------------

SUCCESS: Integrated in Phoenix | 3.0 | Hadoop1 #105 (See [https://builds.apache.org/job/Phoenix-3.0-hadoop1/105/])
PHOENIX-896 Improve PhoenixRuntime cmdline parsing (gabrielr: rev 9eda4def72ce2ccf5bd7186bb0873d1c73b21896)
* phoenix-core/src/test/java/org/apache/phoenix/util/PhoenixRuntimeTest.java
* phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java
* phoenix-core/src/main/java/org/apache/phoenix/util/CSVCommonsLoader.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/CSVCommonsLoaderIT.java


> Improve cmdline parsing of psql (PhoenixRuntime)
> ------------------------------------------------
>
>                 Key: PHOENIX-896
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-896
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-896.patch
>
>
> PhoenixRuntime (the class that is run via the "psql" command) does its own custom command-line
parameter parsing, which has a number of limitations. One of the biggest issues is that it
depends on the ordering of named parameters vs unnamed (i.e. file parameters), and starts
performing actions as part of the command-line parameter parsing. This can lead to some files
being run/imported, and then the tool stopping with an error due to an unexpected command-line
parameter.
> An additional (but probably less important) issue is that the current parameter parsing
is difficult to debug and test (there are currently no automated tests).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message