phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix 180
Date Tue, 26 Aug 2014 03:49:22 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/8#discussion_r16694641
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseParallelIteratorsRegionSplitterIT.java
---
    @@ -86,10 +87,14 @@ protected void initTableValues(long ts) throws Exception {
             conn.close();
         }
     
    -    protected static TableRef getTableRef(Connection conn, long ts) throws SQLException
{
    +    protected static TableRef getTableRef(Connection conn, long ts, PTable pTable) throws
SQLException {
             PhoenixConnection pconn = conn.unwrap(PhoenixConnection.class);
    -        TableRef table = new TableRef(null,pconn.getMetaDataCache().getTable(new PTableKey(pconn.getTenantId(),
STABLE_NAME)),ts, false);
    -        return table;
    +        if (pTable == null) {
    --- End diff --
    
    Is this function really worth sharing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message