phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix 180
Date Tue, 26 Aug 2014 05:28:12 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/8#discussion_r16696289
  
    --- Diff: phoenix-protocol/src/main/StatisticsCollect.proto ---
    @@ -0,0 +1,20 @@
    +option java_package = "org.apache.phoenix.coprocessor.generated";
    +option java_outer_classname = "StatCollectorProtos";
    +option java_generic_services = true;
    +option java_generate_equals_and_hash = true;
    +option optimize_for = SPEED;
    +
    +
    +message StatCollectRequest {
    +  required bytes tenantIdBytes = 1;
    +  required bytes schemaNameBytes = 2;
    --- End diff --
    
    Include both schemaNameBytes and tableNameBytes here.
    Also, add a bytes startRow and bytes stopRow so we can do a "partial" status update. This
will be especially useful to enable a tenant-specific table to update only its own stats.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message