phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix 180
Date Tue, 26 Aug 2014 05:32:51 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/8#discussion_r16696378
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -461,6 +471,57 @@ public MutationState createTable(CreateTableStatement statement,
byte[][] splits
             MutationPlan plan = compiler.compile(Collections.singletonList(tableRef), emptyCF,
null, null, tableRef.getTimeStamp());
             return connection.getQueryServices().updateData(plan);
         }
    +    
    +    public MutationState updateStatistics(UpdateStatisticsStatement updateStatisticsStmt)
throws SQLException {
    +        String tableName = updateStatisticsStmt.getTable().getName().getTableName();
    +        HTableInterface ht = null;
    +        byte[] tenIdBytes = QueryConstants.EMPTY_BYTE_ARRAY;
    +        if (connection.getTenantId() != null) {
    +            tenIdBytes = connection.getTenantId().getBytes();
    +        }
    +        byte[] schNameInBytes = QueryConstants.EMPTY_BYTE_ARRAY;
    +        if (connection.getSchema() != null) {
    +            schNameInBytes = Bytes.toBytes(connection.getSchema());
    +        }
    +        final byte[] tenantIdBytes = tenIdBytes;
    +        final byte[] schemaNameInBytes = schNameInBytes;
    +        try {
    +            ht = connection.getQueryServices().getTable(Bytes.toBytes(tableName));
    +            Batch.Call<StatCollectService, StatCollectResponse> callable = new
Batch.Call<StatCollectService, StatCollectResponse>() {
    +                ServerRpcController controller = new ServerRpcController();
    +                BlockingRpcCallback<StatCollectResponse> rpcCallback = new BlockingRpcCallback<StatCollectResponse>();
    +
    +                @Override
    +                public StatCollectResponse call(StatCollectService service) throws IOException
{
    +                    StatCollectRequest.Builder builder = StatCollectRequest.newBuilder();
    +                    builder.setTenantIdBytes(HBaseZeroCopyByteString.wrap(tenantIdBytes));
    +                    builder.setSchemaNameBytes(HBaseZeroCopyByteString.wrap(schemaNameInBytes));
    --- End diff --
    
    Should be a builder.steTableNameBytes too, as schemaName and tableName are separate -
see other calls on MetaDataEndpointImpl.
    
    We should also add a startRow/stopRow so we can do a partial update of stats. See note
in protobuf def of stats request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message