phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1199) Determine options for Phoenix 4.1.x supporting CDH 5.1
Date Sat, 23 Aug 2014 17:14:10 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108056#comment-14108056
] 

Andrew Purtell commented on PHOENIX-1199:
-----------------------------------------

The ServerName "problem" as far as I'm concerned is a self inflicted wound on the CDH side.
There was no reason to remove the valueOf static methods as this was an API addition, doubly
bad because without them there is no common way to create ServerName objects (constructors
are private in Apache HBase), and ServerName is a public API. In Apache HBase the constructors
are private but a bit of reflection can make them accessible. We can make this work by introducing
a ServerName facade into Phoenix. Wherever else there are similar differences we can take
the same approach. In this specific case instead of a facade we could make the ServerName
constructors public in the next 0.98 release. Of course we'd have to bump the min 0.98 version
Phoenix supports higher than 0.98.4. 

bq. Are there other problematic class references?

Yes, all of the RPC changes we put into 0.98.4 for deadlock avoidance in Phoenix secondary
indexing are not in CDH 5.1, nor in CDH 5.2. This is not something we can fix with a small
tweak to Apache HBase. It's not worth it in my opinion. 

bq. Or should we just wait for the next patch release from Cloudera and ask nicely that they
make it more compatible?

I think we need to wait for CDH 5.3 and request a rebase on an upstream HBase version >=
0.98.4. 

> Determine options for Phoenix 4.1.x supporting CDH 5.1 
> -------------------------------------------------------
>
>                 Key: PHOENIX-1199
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1199
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.1
>            Reporter: James Taylor
>
> Let's figure out the most painless way of supporting CDH 5.1 for Phoenix 4.1. I'm not
as concerned with compile-time, as we know we have a dependency on HBase 0.98.4 (to fix a
deadlock issue). However, this is not a runtime dependency. But the lack of the ServerName
is going to be a problem at runtime. Are there other problematic class references?
> What are our options? Should we try to get something in the next HBase release that'll
help (making constructors public, for example)? Or can we not use ServerName in the Phoenix
code? Are the old HBase APIs available still? You all would know better than me.
> Or should we just wait for the next patch release from Cloudera and ask nicely that they
make it more compatible? smile :-)
> [~apurtell], [~stack], [~lhofhansl], [~jesse_yates]



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message