phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-1225
Date Wed, 03 Sep 2014 06:13:43 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/9#discussion_r17032875
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java ---
    @@ -685,7 +685,7 @@ private KeySlots orKeySlots(OrExpression orExpression, List<KeySlots>
childSlots
                         for (KeySlot slot : childSlot) {
                             // We have a nested OR with nothing for this slot, so continue
                             if (slot == null) {
    -                            continue; // FIXME: I don't think this is ever necessary
    +                            return null; //If one childSlot does not have the PK columns,
let Phoenix scan all the key ranges of the table. 
    --- End diff --
    
    Please include a new unit test - perhaps in QueryIT or feel free to create your own -
that demonstrates a need for the fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message