phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <>
Subject [GitHub] phoenix pull request: Phoenix 180
Date Wed, 03 Sep 2014 16:56:47 GMT
Github user ramkrish86 commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/
    @@ -138,14 +146,10 @@ public boolean apply(HRegionLocation location) {
             //    split each region in s splits such that:
             //    s = max(x) where s * x < t
    -        // The idea is to align splits with region boundaries. If rows are not evenly
    -        // distributed across regions, using this scheme compensates for regions that
    -        // have more rows than others, by applying tighter splits and therefore spawning
    -        // off more scans over the overloaded regions.
    -        int splitsPerRegion = getSplitsPerRegion(regions.size());
             // Create a multi-map of ServerName to List<KeyRange> which we'll use to
round robin from to ensure
             // that we keep each region server busy for each query.
    -        ListMultimap<HRegionLocation,KeyRange> keyRangesPerRegion = ArrayListMultimap.create(regions.size(),regions.size()
* splitsPerRegion);;
    +        int splitsPerRegion = getSplitsPerRegion(regions.size());
    +        ListMultimap<HRegionLocation,KeyRange> keyRangesPerRegion = ArrayListMultimap.create(regions.size(),regions.size()
* splitsPerRegion);
             if (splitsPerRegion == 1) {
                 for (HRegionLocation region : regions) {
    --- End diff --
    @JamesRTaylor - So for a single guide post it will be from empty byte array to the guide
post and from that guidepost to the last empty byte array.  Now when I intersect this with
the available regions then it becomes different and thus not able to use that split. I will
check once again and get back on that.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message