phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix-180
Date Thu, 11 Sep 2014 08:17:47 GMT
Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/12#discussion_r17408963
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/cache/GlobalCache.java ---
    @@ -74,8 +74,8 @@ public void clearTenantCache() {
                     if(result == null) {
                         long maxSize = config.getLong(QueryServices.MAX_SERVER_METADATA_CACHE_SIZE_ATTRIB,
                                 QueryServicesOptions.DEFAULT_MAX_SERVER_METADATA_CACHE_SIZE);
    -                    long maxTTL = config.getLong(QueryServices.MAX_SERVER_METADATA_CACHE_TIME_TO_LIVE_MS_ATTRIB,
    --- End diff --
    
    Ya. That was based on the previous pull request comment where it was said that let the
max TTL time of the Globalcache be equal to the stats updation frequency.  Do you feel it
has to be reverted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message