phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <>
Subject [GitHub] phoenix pull request: Phoenix-180
Date Thu, 11 Sep 2014 09:08:33 GMT
Github user ramkrish86 commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/
    @@ -117,121 +125,59 @@ public boolean apply(HRegionLocation location) {
         protected List<KeyRange> genKeyRanges(List<HRegionLocation> regions)
    -        if (regions.isEmpty()) {
    -            return Collections.emptyList();
    +        if (regions.isEmpty()) { return Collections.emptyList(); }
    +        List<PColumnFamily> columnFamilies = this.tableRef.getTable().getColumnFamilies();
    --- End diff --
    If we do the above of using only  SchemaUtil.getEmptyColumnFamily(table) do we need to
get from the scan. I actually did that from scan only but later reverted it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message