phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix-180
Date Thu, 11 Sep 2014 09:38:55 GMT
Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/12#discussion_r17412153
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java ---
    @@ -220,6 +227,23 @@
                 HConstants.VERSIONS + "=" + MetaDataProtocol.DEFAULT_MAX_META_DATA_VERSIONS
+ ",\n" +
                 HTableDescriptor.SPLIT_POLICY + "='" + MetaDataSplitPolicy.class.getName()
+ "'\n";
         
    +    public static final String CREATE_STATS_TABLE_METADATA = 
    +            "CREATE TABLE " + SYSTEM_CATALOG_SCHEMA + ".\"" + SYSTEM_STATS_TABLE + "\"(\n"
+
    +            // PK columns
    +            TABLE_SCHEM + " VARCHAR NULL," +
    +            TABLE_NAME  + " VARCHAR NOT NULL," +
    +            COLUMN_NAME + " VARCHAR," +
    --- End diff --
    
    As said if we have only PHYSICAL_NAME - it would still have the schemaid also in it? If
it is null and we add SEPEARTOR BYTE in future if we want to retrieve the physical name from
the Result set it will not work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message