phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jyates <...@git.apache.org>
Subject [GitHub] phoenix pull request: Logging custom annotations for PHOENIX-1198
Date Tue, 16 Sep 2014 23:07:27 GMT
Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636321
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java ---
    @@ -86,9 +89,16 @@ public static Connection getConnectionWithoutTracing(Properties props)
throws SQ
             conn.setAutoCommit(false);
             return conn;
         }
    +    
    +    public static Connection getTracingConnection() throws Exception { 
    +    	return getTracingConnection(new HashMap<String, String>(0));
    --- End diff --
    
    could use Collections.emptyMap() here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message