phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jyates <...@git.apache.org>
Subject [GitHub] phoenix pull request: Logging custom annotations for PHOENIX-1198
Date Tue, 16 Sep 2014 23:11:39 GMT
Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636519
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
    @@ -153,6 +159,7 @@ public static void setSampling(Properties props, Frequency freq) {
         public static TraceScope startNewSpan(PhoenixConnection connection, String string)
{
             Sampler<?> sampler = connection.getSampler();
             TraceScope scope = Trace.startSpan(string, sampler);
    +        addCustomAnnotationsToSpan(scope.getSpan(), connection);
    --- End diff --
    
    customAnnotations seems the wrong name. Maybe something like "addConnectionAnnotations"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message