phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jyates <...@git.apache.org>
Subject [GitHub] phoenix pull request: Logging custom annotations for PHOENIX-1198
Date Tue, 16 Sep 2014 23:14:03 GMT
Github user jyates commented on the pull request:

    https://github.com/apache/phoenix/pull/15#issuecomment-55827917
  
    This would be a lot nicer if you didn't mix the logging changes with the tracing changes
- the changelist would be much more succinct and to the point. Otherwise, seems like the right
approach, though it could use some cleanup (docs, readability, etc)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message