phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From elilevine <...@git.apache.org>
Subject [GitHub] phoenix pull request: Logging custom annotations for PHOENIX-1198
Date Wed, 17 Sep 2014 03:42:56 GMT
Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17644459
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.util;
    +
    +import java.util.Map;
    +
    +public class LogUtil {
    --- End diff --
    
    Tracing-only changes are in PR #13. This PR was supposed to be only for logging-related
code but I screwed it up because I pulled in my tracing changes used in #13 because for logging
I am using the same way to pass annotations in. Tried to make that clear in this PR's description
but clearly failed. Sorry about that. Maybe take a look at #13 that has tracing-only changes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message