phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix-180
Date Wed, 17 Sep 2014 09:09:58 GMT
Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/12#discussion_r17653749
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java ---
    @@ -851,14 +895,18 @@ public static PTable createFromProto(PTableProtos.PTable table)
{
           for (PTableProtos.PTable curPTableProto : table.getIndexesList()) {
             indexes.add(createFromProto(curPTableProto));
           }
    +      List<PColumnFamily> columnFamilies = Lists.newArrayListWithExpectedSize(table.getColumnfamiliesCount());
    --- End diff --
    
    Actually there was no PColumnFamily in the proto file. So added that and creating those
from the Proto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message