phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1198) Add ability to pass custom tags to be added to log lines
Date Tue, 16 Sep 2014 23:09:35 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136457#comment-14136457
] 

ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------

Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636396
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/LogUtil.java ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.util;
    +
    +import java.util.Map;
    +
    +public class LogUtil {
    --- End diff --
    
    This seems a strange way to handle it, when used in practice. Its not entirely clear that
all the log elements should be annotated. In fact, it would be nice, at least in this initial
pass, to separate the logging from the tracing in terms of the per-connection annotations.


> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
>                 Key: PHOENIX-1198
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1198
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling upsert/select.
Similar to PHOENIX-1196. Maybe they can shared the same mechanism for passing in values to
be logged/traced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message