phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1198) Add ability to pass custom tags to be added to log lines
Date Tue, 16 Sep 2014 23:12:33 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136464#comment-14136464
] 

ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------

Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636519
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
    @@ -153,6 +159,7 @@ public static void setSampling(Properties props, Frequency freq) {
         public static TraceScope startNewSpan(PhoenixConnection connection, String string)
{
             Sampler<?> sampler = connection.getSampler();
             TraceScope scope = Trace.startSpan(string, sampler);
    +        addCustomAnnotationsToSpan(scope.getSpan(), connection);
    --- End diff --
    
    customAnnotations seems the wrong name. Maybe something like "addConnectionAnnotations"?


> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
>                 Key: PHOENIX-1198
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1198
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling upsert/select.
Similar to PHOENIX-1196. Maybe they can shared the same mechanism for passing in values to
be logged/traced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message