phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1198) Add ability to pass custom tags to be added to log lines
Date Tue, 16 Sep 2014 23:12:34 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136467#comment-14136467
] 

ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------

Github user jyates commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17636539
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java ---
    @@ -257,6 +264,18 @@ public static Span child(Span s, String d) {
         public static CallWrapper withTracing(PhoenixConnection conn, String desc) {
             return new TracingWrapper(conn, desc);
         }
    +    
    +    private static void addCustomAnnotationsToSpan(@Nullable Span span, @NotNull PhoenixConnection
conn) {
    +        Preconditions.checkNotNull(conn);
    +        
    +        if (span != null) {
    --- End diff --
    
    nit: flip the logic and save the indent for readabililty


> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
>                 Key: PHOENIX-1198
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1198
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling upsert/select.
Similar to PHOENIX-1196. Maybe they can shared the same mechanism for passing in values to
be logged/traced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message