phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1198) Add ability to pass custom tags to be added to log lines
Date Wed, 17 Sep 2014 03:39:34 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136726#comment-14136726
] 

ASF GitHub Bot commented on PHOENIX-1198:
-----------------------------------------

Github user elilevine commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/15#discussion_r17644317
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/trace/BaseTracingTestIT.java ---
    @@ -86,9 +89,16 @@ public static Connection getConnectionWithoutTracing(Properties props)
throws SQ
             conn.setAutoCommit(false);
             return conn;
         }
    +    
    +    public static Connection getTracingConnection() throws Exception { 
    +    	return getTracingConnection(new HashMap<String, String>(0));
    --- End diff --
    
    Generics gets screwed up if emptyMap() is used in the parameter. I'll see what I can do
to make this cleaner.


> Add ability to pass custom tags to be added to log lines
> --------------------------------------------------------
>
>                 Key: PHOENIX-1198
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1198
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>
> These tags can be passed in either when creating connections or calling upsert/select.
Similar to PHOENIX-1196. Maybe they can shared the same mechanism for passing in values to
be logged/traced.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message