phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1245) Remove usage of empty KeyValue object BATCH_MARKER from Indexer
Date Tue, 09 Sep 2014 18:36:29 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127349#comment-14127349
] 

Jesse Yates commented on PHOENIX-1245:
--------------------------------------

The analysis here is correct - it so we keep the WALEdit around for the second CP call. But
since the HBase API changed, we should be good. However, we have to be careful that we maintain
backwards compatibility with older versions of HBase

> Remove usage of empty KeyValue object BATCH_MARKER from Indexer
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-1245
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1245
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 5.0.0, 4.2
>
>
> This is added to WALEdit in one CP hook and removed in a later CP hook. But not really
used.
> Now after HBASE-11805, the removal won't really happen. Later this empty KV is used in
other part of HBase core code and resulting in NPE as the bytes ref in this KV is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message