phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <>
Subject [jira] [Updated] (PHOENIX-1245) Remove usage of empty KeyValue object BATCH_MARKER from Indexer
Date Thu, 11 Sep 2014 14:06:34 GMT


Anoop Sam John updated PHOENIX-1245:
    Attachment: PHOENIX-1245.patch

On running the IT tests got one issue which was not analyzed.
Fixing that also in the new patch
With this the index related IT tests pass.

This is the extra change
     WALEdit edit = miniBatchOp.getWalEdit(0);
+    if (edit == null) {
+        edit = new WALEdit();
+        miniBatchOp.setWalEdit(0, edit);
+    }
Previously there were WALEdit object at every index of the miniBatchOp as we add one in prePut/Delete.
Now as we don't have this, we have to create and set.

Pls review

> Remove usage of empty KeyValue object BATCH_MARKER from Indexer
> ---------------------------------------------------------------
>                 Key: PHOENIX-1245
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 5.0.0, 4.2
>         Attachments: PHOENIX-1245.patch, PHOENIX-1245.patch
> This is added to WALEdit in one CP hook and removed in a later CP hook. But not really
> Now after HBASE-11805, the removal won't really happen. Later this empty KV is used in
other part of HBase core code and resulting in NPE as the bytes ref in this KV is null.

This message was sent by Atlassian JIRA

View raw message