phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1264) Add StatisticsCollector to existing tables on first connection to cluster
Date Fri, 26 Sep 2014 04:15:33 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148713#comment-14148713
] 

ramkrishna.s.vasudevan commented on PHOENIX-1264:
-------------------------------------------------

bq.Instead of changing the default in individual sources (as shown below)
I have not changed for all the testcases.  The default has been updated in the QueryServicesTestImpl.
But these test cases need the value to be lower so that I can assert what am collecting. 
So I think that is fine? No?
bq.Minor nit: how about "_AnalyzeTable" 
Ok. 
bq.Can we cover these checks with a new ScanUtil.isAnalyzeTable(Scan scan) call instead?
Fine.
bq. updateCache(table.getSchemaName().getString(), table.getTableName().getString(), true);
Ok I will once verify this.  

> Add StatisticsCollector to existing tables on first connection to cluster
> -------------------------------------------------------------------------
>
>                 Key: PHOENIX-1264
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1264
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: Phoenix-1264_1.patch, Phoenix-1264_2.patch
>
>
> We'll need to add the StatisticsCollector to existing tables so that stats are kept for
these tables. We typically do that on first connection to the cluster in ensureTableCreated
when our system table is created by walking through the existing Phoenix tables. We only need
to do it if the system table already exists (otherwise, it's a new installation).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message