phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1281) Each MultiKeyValueTuple.setKeyValues creates a new immutable list object
Date Thu, 25 Sep 2014 16:03:34 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147897#comment-14147897
] 

Hudson commented on PHOENIX-1281:
---------------------------------

FAILURE: Integrated in Phoenix | Master | Hadoop1 #383 (See [https://builds.apache.org/job/Phoenix-master-hadoop1/383/])
PHOENIX-1281 Each MultiKeyValueTuple.setKeyValues creates a new immutable list object. (larsh:
rev ea5a797ebcd611670c5400aa7aaae3b3b414c43d)
* phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/MultiKeyValueTuple.java
* phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ScanRegionObserver.java


> Each MultiKeyValueTuple.setKeyValues creates a new immutable list object
> ------------------------------------------------------------------------
>
>                 Key: PHOENIX-1281
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1281
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 5.0.0, 4.2, 3.2
>
>         Attachments: 1281-v1.txt
>
>
> I looked through all callers of this method, and in each case we have a fresh List object
anyway, and hence the wrapping is not necessary saving at least one new object per row scanned.
> This is probably not really critical, but of a sizable COUNT(\*) or other aggregate it
still creates lot of unnecessary objects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message