phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samarth Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1298) Queries on fixed width type columns that have an index declared on them don't use that index
Date Sat, 27 Sep 2014 07:38:34 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150493#comment-14150493
] 

Samarth Jain commented on PHOENIX-1298:
---------------------------------------

Hmm. I think there is some confusion here. I just pulled your latest changes and I still see
my test case failing. The test that you have committed in QueryOptimizerTest uses RVC. The
test that I am talking about doesn't use RVC. 

Test that was commited by you:
{code}
@Test
    public void testRVCUsingPkColsReturnedByPlanShouldUseIndex() throws Exception {
        Connection conn = DriverManager.getConnection(getUrl());
        conn.createStatement().execute("CREATE TABLE T (k VARCHAR NOT NULL PRIMARY KEY, v1
CHAR(15), v2 VARCHAR)");
        conn.createStatement().execute("CREATE INDEX IDX ON T(v1, v2)");
        PhoenixStatement stmt = conn.createStatement().unwrap(PhoenixStatement.class);
        String query = "select * from t where (v1, v2, k) > ('1', '2', '3')";
        QueryPlan plan = stmt.optimizeQuery(query);
        assertEquals("IDX", plan.getTableRef().getTable().getTableName().getString());
  }
{code}  

Test I am talking about:
{code}
@Test
    public void testQueryPlanForQueryUsingIndexOnFixedWidthColumn() throws Exception {
        Connection conn = DriverManager.getConnection(getUrl());
        conn.createStatement().execute("CREATE TABLE T (k VARCHAR NOT NULL PRIMARY KEY, v1
CHAR(15), v2 VARCHAR)");
        conn.createStatement().execute("CREATE INDEX IDX ON T(v1)");
        PhoenixStatement stmt = conn.createStatement().unwrap(PhoenixStatement.class);
        String query = "select * from t where v1 = '1'";
        QueryPlan plan = stmt.optimizeQuery(query);
        assertEquals("IDX", plan.getTableRef().getTable().getTableName().getString());
    }
{code}

> Queries on fixed width type columns that have an index declared on them don't use that
index
> --------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1298
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1298
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.2, 3.2
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>             Fix For: 5.0.0, 4.2, 3.2
>
>         Attachments: PHOENIX-1298.patch, PHOENIX-1298.patch
>
>
> Happens when the index is on a column whose data type is fixed width. If V1 is made of
type VARCHAR, then the test passes.
> {code}
> @Test
>     public void testRVCUsingPkColsReturnedByPlanShouldUseIndex() throws Exception {
>         Connection conn = DriverManager.getConnection(getUrl());
>         conn.createStatement().execute("CREATE TABLE T (k VARCHAR NOT NULL PRIMARY KEY,
v1 CHAR(15), v2 VARCHAR)");
>         conn.createStatement().execute("CREATE INDEX IDX ON T(v1)");
>         PhoenixStatement stmt = conn.createStatement().unwrap(PhoenixStatement.class);
>         String query = "select * from t where v1 = '1'";
>         QueryPlan plan = stmt.optimizeQuery(query);
>         assertEquals("IDX", plan.getTableRef().getTable().getTableName().getString());
>     }
>  
> {code}
> Instead of going through the index table, the query ends up using the data table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message