phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix 180 1
Date Thu, 04 Sep 2014 06:48:51 GMT
GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/phoenix/pull/10

    Phoenix 180 1

    A new pull request with updated comments.  Still trying to test the performance with these
changes.
    -> Test cases are not running and all the test cases are failing at the deleteTable
sequence.
    -> The checking of the timestamp stored in the table and avoiding concurrent update
stats does not work. I am checking on it.
    -> The clearing of the metadata cache should happen in a lock? If so then we need to
see every where (even while reading from the cache) we should introduce a new lock.
    -> Estimated byte size() is yet to be added to Ptable
    -> Multi CF is not yet tested.  
    But this would help in getting the review done on the latest changes.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/phoenix-1 Phoenix-180_1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit df59996c9c0b19a44262de36e28d34de910faaaa
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2014-08-22T08:48:19Z

    Phoenix-180

commit 09f8ebdcc468ac9fdce9a62ea7377d62c294d2a9
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2014-08-25T12:45:26Z

    Phoenix-180

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message