phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-900) Partial results for mutations
Date Wed, 25 Feb 2015 19:50:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337063#comment-14337063
] 

ASF GitHub Bot commented on PHOENIX-900:
----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/37#discussion_r25372379
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java ---
    @@ -426,6 +430,7 @@ public Void call() throws SQLException {
                     return null;
                 }
             }, Tracing.withTracing(this, "committing mutations"));
    +        statementExecutionCounter = 0;
         }
    --- End diff --
    
    Instead of mucking with the MutationState methods and having to add a setter for the state,
how about this (part 1 of 3)?
    {code}
            // In PhoenixConnection constructor, have construction of MutationState
            // go through method on PhoenixConnection to enable tests to specialize
            // the method
            this.mutationState = newMutationState(maxSize);
            this.services.addConnection(this);
    
            // setup tracing, if its enabled
            this.sampler = Tracing.getConfiguredSampler(this);
            this.customTracingAnnotations = getImmutableCustomTracingAnnotations();
        }
        
        protected MutationState newMutationState(int maxSize) {
            return new MutationState(maxSize, this); 
        }
        



> Partial results for mutations
> -----------------------------
>
>                 Key: PHOENIX-900
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-900
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>         Attachments: PHOENIX-900.patch
>
>
> HBase provides a way to retrieve partial results of a batch operation: http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html#batch%28java.util.List,%20java.lang.Object[]%29
> Chatted with James about this offline:
> Yes, this could be included in the CommitException we throw (MutationState:412). We already
include the batches that have been successfully committed to the HBase server in this exception.
Would you be up for adding this additional information? You'd want to surface this in a Phoenix-y
way in a method on CommitException, something like this: ResultSet getPartialCommits(). You
can easily create an in memory ResultSet using MaterializedResultIterator plus the PhoenixResultSet
constructor that accepts this (just create a new empty PhoenixStatement with the PhoenixConnection
for the other arg).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message