phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-900) Partial results for mutations
Date Tue, 17 Feb 2015 01:20:11 GMT


ASF GitHub Bot commented on PHOENIX-900:

Github user JamesRTaylor commented on a diff in the pull request:
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ ---
    @@ -156,7 +157,7 @@ private static MutationState upsertSelect(PhoenixStatement statement,
                                 column.getMaxLength(), column.getScale(), column.getSortOrder());
                         values[i] = ByteUtil.copyKeyBytesIfNecessary(ptr);
    -                setValues(values, pkSlotIndexes, columnIndexes, table, mutation);
    +                setValues(values, pkSlotIndexes, columnIndexes, table, mutation, statement);
    --- End diff --
    Note that this statement may have been cloned from the original statement with a clone
of the original connection since this upsertSelect is called in parallel by multiple threads
in a upsert select statement. Is that going to be ok for linking back to the statement index
in your case?

> Partial results for mutations
> -----------------------------
>                 Key: PHOENIX-900
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>         Attachments: PHOENIX-900.patch
> HBase provides a way to retrieve partial results of a batch operation:,%20java.lang.Object[]%29
> Chatted with James about this offline:
> Yes, this could be included in the CommitException we throw (MutationState:412). We already
include the batches that have been successfully committed to the HBase server in this exception.
Would you be up for adding this additional information? You'd want to surface this in a Phoenix-y
way in a method on CommitException, something like this: ResultSet getPartialCommits(). You
can easily create an in memory ResultSet using MaterializedResultIterator plus the PhoenixResultSet
constructor that accepts this (just create a new empty PhoenixStatement with the PhoenixConnection
for the other arg).

This message was sent by Atlassian JIRA

View raw message