phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1639) Enhance function/expression index tests
Date Sat, 14 Feb 2015 00:40:12 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321045#comment-14321045
] 

ASF GitHub Bot commented on PHOENIX-1639:
-----------------------------------------

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/36#discussion_r24708905
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseViewIT.java ---
    @@ -130,7 +130,7 @@ protected void testUpdatableViewIndex(Integer saltBuckets, boolean
localIndex) t
             rs = conn.createStatement().executeQuery("EXPLAIN " + query);
             String queryPlan = QueryUtil.getExplainPlan(rs);
             if (localIndex) {
    -            assertEquals("CLIENT PARALLEL 3-WAY RANGE SCAN OVER _LOCAL_IDX_T [-32768,51]\n"
    +            assertEquals("CLIENT PARALLEL "+ (saltBuckets == null ? 1 : saltBuckets)
 +"-WAY RANGE SCAN OVER _LOCAL_IDX_T [-32768,51]\n"
    --- End diff --
    
    Added this so that I could add testNonSaltedUpdatableViewWithLocalIndex to ViewIT


> Enhance function/expression index tests
> ---------------------------------------
>
>                 Key: PHOENIX-1639
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1639
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>
> Add tests for views, negative scenarios, sort order of expression. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message