phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1639) Enhance function/expression index tests
Date Sat, 14 Feb 2015 02:28:11 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321166#comment-14321166
] 

ASF GitHub Bot commented on PHOENIX-1639:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/36#discussion_r24711078
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -435,6 +435,9 @@ private boolean addIndexesFromPhysicalTable(MetaDataMutationResult
result) throw
                     boolean containsAllReqdCols = true;
                     // Ensure that all indexed columns from index on physical table
                     // exist in the view too (since view columns may be removed)
    +                // TODO 
    --- End diff --
    
    You'll want to try to compile the expression and detect if it fails.
    
    >



> Enhance function/expression index tests
> ---------------------------------------
>
>                 Key: PHOENIX-1639
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1639
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>
> Add tests for views, negative scenarios, sort order of expression. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message