phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-787) CEIL function may produce incorrect results for TIMESTAMP
Date Sun, 12 Apr 2015 20:40:12 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491703#comment-14491703
] 

ASF GitHub Bot commented on PHOENIX-787:
----------------------------------------

GitHub user naveenmadhire opened a pull request:

    https://github.com/apache/phoenix/pull/66

    PHOENIX-787  Ceil Function Test Case

    Please let me know if my understanding is correct. I wrote this test case similar to RoundFloorCeilFunctionsEnd2EndIT.
I tried with milliseconds = 1000 and I see that the output after ceil is rounding to the next
increment. 
    
    So, is this already working or do we need to change anything else for solving this issue?
    
    Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/naveenmadhire/phoenix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit 1736646d1df1ab53cb2d54168d11557783f1e5b5
Author: NAVEEN MADHIRE <vmadhire@indiana.edu>
Date:   2015-04-12T20:34:57Z

    PHOENIX-787

----


> CEIL function may produce incorrect results for TIMESTAMP
> ---------------------------------------------------------
>
>                 Key: PHOENIX-787
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-787
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 3.0-Release
>            Reporter: James Taylor
>              Labels: Newbie
>
> In the CEIL function, we only consider nanos when the time unit of MILLISECONDS is used.
However, we should consider it for other time units as well. For example, if the time unit
is SECONDS and the TIMESTAMP value happens to be at an exact multiple of 1000 milliseconds,
then the CEIL should round up, as their will be nano seconds remaining and thus the TIMESTAMP
should be rounded up to the next increment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message