phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-900) Partial results for mutations
Date Tue, 21 Apr 2015 23:55:58 GMT


ASF GitHub Bot commented on PHOENIX-900:

GitHub user elilevine reopened a pull request:

    Surface partial saves in CommitExcepiton (PHOENIX-900)

You can merge this pull request into a Git repository by running:

    $ git pull PHOENIX-900

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
commit 10754f7ab71d62349acb2e18e79a91ded7bc6c62
Author: Eli Levine <>
Date:   2015-02-06T00:28:33Z

    First pass at impl. Not tested.

commit d8ea1db808434ca1d159d6316105d50dbd0bca82
Author: Eli Levine <>
Date:   2015-02-10T01:40:28Z

    First attempt at a new integ test for partial commits using a coproc. Still WIP.

commit 34302cfac39d3d893103a99886d10a3fc8e65d58
Author: Eli Levine <>
Date:   2015-02-11T23:16:28Z

    Test now successfully verifies partial upsert failure. Statement ordering still borked.
Prolly need to swith to keeping order of statement execution instead of creation.

commit 6f7bc57646543a08222e652f264ee02b6b3e1241
Author: Eli Levine <>
Date:   2015-02-12T00:41:34Z

    Switched to keeping a count of statement executions instead of creations, which is ultimately
used in MutationState. Basic partial commit test working.

commit 74e3ba6ce1bf12de62d1b3859e23b6ce224bd370
Author: Eli Levine <>
Date:   2015-02-12T02:04:14Z

    Modify PartialCommitIT to add select clause

commit 265b2e90056bca13b8ba59efba15841c9a8658ef
Author: Eli Levine <>
Date:   2015-02-13T01:26:51Z

    Separated getting and incrementing of PhoenixConnection's statement execution counter.
More tests. Still WIP.

commit 0f8958b3debb2f391a230f51b29fe102b426c9be
Author: Eli Levine <>
Date:   2015-02-15T22:55:21Z

    Fix partial success w/ delete test

commit 29ae22f5c3bec7dbd659b16edcaa4904fd1c1cd8
Author: Eli Levine <>
Date:   2015-02-16T04:43:03Z

    Clarify that partial save statement tracking is only supported for operations on data,
not metadata.

commit 5ee273cf36729fab0bf9613bfead5933c920bd35
Author: Eli Levine <>
Date:   2015-02-16T19:55:30Z

    Add data verification after partial saves to PartialCommitIT

commit 6619e44e20e0a923dbe817191ae9c06266856e7d
Author: Eli Levine <>
Date:   2015-02-17T21:15:18Z

    Carry statement counter in PhoenixConnection copy constructors. Add more partial commit
testing around SELECT UPSERT. Formatting fixes.

commit bfe6a537a4cb1256962c679e36d1a33250623af6
Author: Eli Levine <>
Date:   2015-02-17T21:27:14Z

    Method name change for CommitException

commit 596e48f6e82fbaa0e21e26045a8b789882392a03
Author: Eli Levine <>
Date:   2015-02-18T19:56:57Z

    Switch from Set<Integer> to int[] to hold statement indexes in MutationState

commit 5fa951973eeccea338632696de03d7256c0639a3
Author: Eli Levine <>
Date:   2015-02-23T22:52:06Z

    Switch back to using HashMap for MutationState.mutations and only use TreeMap for testing

commit b0e44da6d408fa40c1a53209a9a8a7f635ff43aa
Author: Eli Levine <>
Date:   2015-02-23T23:28:41Z

    Merge upstream changes

commit 48a939268ec0056c44d38d4cfe666a6cab9aa1cb
Author: Eli Levine <>
Date:   2015-02-26T20:11:23Z

    Slightly modify how MutationState.mutations is overriden in tests

commit 935ecc0d32aba8cda77bef05486649686a050fa9
Author: Eli Levine <>
Date:   2015-02-27T04:25:16Z

    Improve constructor chaining slightly in MutationState

commit 3b114ae584412099370dcde81aa87262e066e49f
Author: Eli Levine <>
Date:   2015-02-27T04:37:07Z

    Merge branch 'master' of into PHOENIX-900

commit 374c51fe697d5dbba6dc972fcc8a29c11c213dce
Author: Eli Levine <>
Date:   2015-04-21T22:28:34Z

    Merge changes from upstream/master

commit 84ea3522707c9b83315e819419300cd2f3a4b27e
Author: Eli Levine <>
Date:   2015-04-21T23:47:18Z

    Fix bug around deletion mutations in MutationState.


> Partial results for mutations
> -----------------------------
>                 Key: PHOENIX-900
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.4.0
>         Attachments: PHOENIX-900.patch
> HBase provides a way to retrieve partial results of a batch operation:,%20java.lang.Object[]%29
> Chatted with James about this offline:
> Yes, this could be included in the CommitException we throw (MutationState:412). We already
include the batches that have been successfully committed to the HBase server in this exception.
Would you be up for adding this additional information? You'd want to surface this in a Phoenix-y
way in a method on CommitException, something like this: ResultSet getPartialCommits(). You
can easily create an in memory ResultSet using MaterializedResultIterator plus the PhoenixResultSet
constructor that accepts this (just create a new empty PhoenixStatement with the PhoenixConnection
for the other arg).

This message was sent by Atlassian JIRA

View raw message