phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1733) sqlline.py doesn't allow connecting with a tenant-specific connection
Date Fri, 17 Apr 2015 16:15:59 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500114#comment-14500114
] 

ASF GitHub Bot commented on PHOENIX-1733:
-----------------------------------------

Github user gabrielreid commented on the pull request:

    https://github.com/apache/phoenix/pull/69#issuecomment-94018951
  
    Looks good, except that this breaks sqlline.py for Windows. Could you take a look at how
psql.py uses the same approach but also uses subprocess.list2cmdline to allow running it on
Windows, and try to use the same approach here?


> sqlline.py doesn't allow connecting with a tenant-specific connection
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-1733
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1733
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>            Assignee: Abhishek Sreenivasa
>              Labels: Newbie
>
> Connecting with a client-specific connection via sqlline.py should work with a command
like the following:
> {code}
> ./bin/sqlline.py 'localhost:2181;TenantId=t1'
> {code}
> However, the command that is built up within sqlline.py doesn't correctly quote the JDBC
url, so the JDBC url parameter ends up as:
> {code}
> jdbc:phoenix:localhost:2181;TenantId=t1
> {code}
> without quoting. This causes the semicolon to be interpreted as a command separator by
the shell, effectively ignoring it (and any other parameters).
> Proper parameter quoting (as done with the pipes module in psql.py) should be used for
sqlline.py to get around this and similar issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message