phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 7shurik <...@git.apache.org>
Subject [GitHub] phoenix pull request: Phoenix 1759
Date Wed, 15 Apr 2015 23:07:35 GMT
GitHub user 7shurik opened a pull request:

    https://github.com/apache/phoenix/pull/68

    Phoenix 1759

    This is a fix for https://issues.apache.org/jira/browse/PHOENIX-1759. There's a set of
unit tests as well as an integration test.
    
    Main code change is adding a PhoenixArray.toString() implementation and toString on each
primitive array type. There're also a couple of fixes for toStringLiteral not to barf on nulls.
    
    Please let me know if you see any problems.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/7shurik/phoenix PHOENIX-1759

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit 9b6a4f049f084edb4d3fb03c960eb37b24d120b2
Author: Alex <awarshavsky@salesforce.com>
Date:   2015-04-15T19:19:08Z

    JIRA PHOENIX-1759 - Fix implementation of PhoenixArray toString(). Includes both object
and primitive arrays.

commit 0fb879e74a3dc55211046c96f30a054a5aeacb67
Author: Alex <awarshavsky@salesforce.com>
Date:   2015-04-15T19:30:32Z

    Add intergration test for array toString()

commit ca6243de97f4bc203278bd129a62e08ffea896f4
Author: Alex <awarshavsky@salesforce.com>
Date:   2015-04-15T23:03:07Z

    Integration test for PhoenixArray ResultSet.getString(), also sync PDataType to latest
trunk version.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message