phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anilgupta84 <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2098 - Udf that given a number bulk ...
Date Fri, 10 Jul 2015 07:40:40 GMT
Github user anilgupta84 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/98#discussion_r34333325
  
    --- Diff: phoenix-pig/src/main/java/org/apache/phoenix/pig/udf/ReserveNSequence.java ---
    @@ -0,0 +1,88 @@
    +/**
    + * 
    + */
    +package org.apache.phoenix.pig.udf;
    +
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
agreements. See the NOTICE
    + * file distributed with this work for additional information regarding copyright ownership.
The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the "License"); you may not use this
file except in compliance with the
    + * License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
Unless required by
    + * applicable law or agreed to in writing, software distributed under the License is
distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License
for the specific language
    + * governing permissions and limitations under the License.
    + */
    +import java.io.IOException;
    +import java.sql.Connection;
    +import java.sql.ResultSet;
    +import java.sql.SQLException;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.phoenix.mapreduce.util.ConnectionUtil;
    +import org.apache.pig.EvalFunc;
    +import org.apache.pig.data.Tuple;
    +import org.apache.pig.impl.util.UDFContext;
    +
    +import com.google.common.base.Preconditions;
    +
    +/**
    + * UDF to Reserve a chunk of numbers for a given sequence
    + * 
    + * @note The way this UDF is invoked we open a new connection for every tuple row. The
UDF will not perform well on
    --- End diff --
    
    i c.. In that case, this UDF is scalable? Or It is non-scalable due to some other reason?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message