phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mujtaba Chohan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2025) Phoenix-core's hbase-default.xml prevents HBaseTestingUtility from starting up in client apps
Date Wed, 01 Jul 2015 17:54:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610723#comment-14610723
] 

Mujtaba Chohan commented on PHOENIX-2025:
-----------------------------------------

Change for hbase.default.for.version.skip=true is checked in:

https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/it/java/org/apache/phoenix/mapreduce/IndexToolIT.java;h=5d11cf2258827de3cf9683eeea2ade8950ab0c69;hp=676127552bee38911a04e828396b826884264fd0;hb=f979dd96127ec2c703556d72b7f89553d3300db2;hpb=f3cb78c51a45204cd02b6eaeb87c52d616de705b

https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=blobdiff;f=phoenix-core/src/it/java/org/apache/phoenix/mapreduce/IndexToolIT.java;h=5d11cf2258827de3cf9683eeea2ade8950ab0c69;hp=676127552bee38911a04e828396b826884264fd0;hb=773d2c69577d4d146d7ca1acf63c2ceca4ea124d;hpb=7535de4131eadcb504198ed39f9bcde0008a1eae



> Phoenix-core's hbase-default.xml prevents HBaseTestingUtility from starting up in client
apps
> ---------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2025
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2025
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>             Fix For: 5.0.0, 4.5.0, 4.4.1
>
>         Attachments: PHOENIX-2025.patch, PHOENIX-2025_v2.patch
>
>
> Phoenix seems to have long had its own version of hbase-default.xml as a test resource
in phoenix-core with a single setting to override hbase.defaults.for.version.skip to true.
Sometime around Phoenix 4.3, phoenix-core seems to have been split into a main jar and a test
jar, and the hbase-default.xml went into the test jar.
> The odd result of this is that in client apps that include the test jar, the classloader
in HBaseConfiguration.create() now sees Phoenix's hbase-default.xml, rather than HBase's,
and creates a Configuration object without HBase's defaults. One major consequence of this
is that the HBaseTestingUtility can't start up, because it relies on those HBase defaults
being set. This is a huge problem in a client app that includes the phoenix-core test jar
in order to make use of the PhoenixTestDriver and BaseTest classes; the upgrade to 4.3 breaks
all tests using the HBaseTestingUtility. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message