phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-2025) Phoenix-core's hbase-default.xml prevents HBaseTestingUtility from starting up in client apps
Date Wed, 01 Jul 2015 18:43:04 GMT


Geoffrey Jacoby commented on PHOENIX-2025:

The IndexToolIT test suite fails for me whether [~tdsilva] 's change is present or not. Setting
a debugger in the setUp method, I see that hbase.default.for.version.skip is set to true whether
or not the call to conf.setBoolean(hbase.default.for.version.skip, true) is commented on or
off, which is what I'd expect to see if hbase-site.xml is correctly being processed. (An "hbase-site.xml"
is also listed in the conf object as one of its files)

It's not, therefore, that we were applying that setting and now we're not. If it turns out
that the failure is related to this JIRA, it would probably be because the test doesn't work
with one of the real hbase-default.xml's settings which is in hbase-common.jar, which is now
being imported when it was formerly blocked by Phoenix's stub hbase-default.xml that just
had hbase.default.for.version.skip.

> Phoenix-core's hbase-default.xml prevents HBaseTestingUtility from starting up in client
> ---------------------------------------------------------------------------------------------
>                 Key: PHOENIX-2025
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>             Fix For: 5.0.0, 4.5.0, 4.4.1
>         Attachments: PHOENIX-2025.patch, PHOENIX-2025_v2.patch
> Phoenix seems to have long had its own version of hbase-default.xml as a test resource
in phoenix-core with a single setting to override hbase.defaults.for.version.skip to true.
Sometime around Phoenix 4.3, phoenix-core seems to have been split into a main jar and a test
jar, and the hbase-default.xml went into the test jar.
> The odd result of this is that in client apps that include the test jar, the classloader
in HBaseConfiguration.create() now sees Phoenix's hbase-default.xml, rather than HBase's,
and creates a Configuration object without HBase's defaults. One major consequence of this
is that the HBaseTestingUtility can't start up, because it relies on those HBase defaults
being set. This is a huge problem in a client app that includes the phoenix-core test jar
in order to make use of the PhoenixTestDriver and BaseTest classes; the upgrade to 4.3 breaks
all tests using the HBaseTestingUtility. 

This message was sent by Atlassian JIRA

View raw message