phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2058) Check for existence and compatibility of columns being added in view
Date Wed, 08 Jul 2015 06:12:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618040#comment-14618040
] 

James Taylor commented on PHOENIX-2058:
---------------------------------------

Thanks, [~tdsilva], +1, but would you mind including the test you removed, but with an Ignore
tag and comment about why? I think we'll want to enable it if PHOENIX-978 gets fixed.

> Check for existence and compatibility of columns being added in view
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-2058
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2058
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2058-WIP.patch, PHOENIX-2058.patch, PHOENIX-2058.v2.patch,
PHOENIX-2058.wip.2.patch
>
>
> One check I realized we're not doing, but need to do, is ensuring that the column being
added by the base table doesn't already exist in the view. If the column does already exist,
ideally we can allow the addition to the base table if the type matches and the scale is null
or >= existing scale and the maxLength is null or >= existing maxLength. Also, if a
column is a PK column and it already exists in the view, the position in the PK must match.

> The fact that we've materialized a PTable for the view should make the addition of this
check easier.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message