phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-2088) Prevent splitting and recombining select expressions for MR integration
Date Thu, 02 Jul 2015 03:17:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611394#comment-14611394
] 

James Taylor edited comment on PHOENIX-2088 at 7/2/15 3:16 AM:
---------------------------------------------------------------

bq. Should we just figure out a better way of serializing the list of names and column infos?
Yes. There are lots of solutions to this. We could always use a base attribute name (like
"SELECT_EXPR") and then tack on a 1, 2, 3, ... for each argument and do the same for the data
type or whatever other info we need to pass through.

The key is to not depend on a delimiter, because it'll always be possible that the delimiter
is used in an expression, so this approach is DOA.


was (Author: jamestaylor):
bq. Should we just figure out a better way of serializing the list of names and column infos?
Yes. There are lots of solutions to this. We could always use a base attribute name (like
"SELECT_EXPR") and then tack on a 1, 2, 3, ... for each argument and do the same for the data
type or whatever other info we need to pass through.

> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-2088
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2088
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-2088-wip.patch
>
>
> We currently send in the select expressions for the MR integration with a delimiter separated
string, split based on the delimiter, and then recombine again using a comma separator. This
is problematic because the delimiter character may appear in a select expression, thus breaking
this logic. Instead, we should use a comma as the delimiter and avoid splitting and recombining
as it's not necessary in that case. Instead, the entire string can be used as-is in that case
to form the select expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message