phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Mahonin (JIRA)" <>
Subject [jira] [Updated] (PHOENIX-2088) Prevent splitting and recombining select expressions for MR integration
Date Thu, 02 Jul 2015 19:38:04 GMT


Josh Mahonin updated PHOENIX-2088:
    Attachment: PHOENIX-2088-wip-v2.patch

Additions to previous patch for phoenix-spark module

Instead of relying on the ColumnInfoEncoderDecoder, I've tweaked the usage of the Configuration
and ColumnInfo objects so that they're never serialized, but instead recreated / derived on
a per-partition basis.

This passes the phoenix-spark integration tests, but the phoenix-pig unit tests are failing,
though I don't think that was caused by my additions. 

> Prevent splitting and recombining select expressions for MR integration
> -----------------------------------------------------------------------
>                 Key: PHOENIX-2088
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: maghamravikiran
>         Attachments: PHOENIX-2088-wip-v2.patch, PHOENIX-2088-wip.patch
> We currently send in the select expressions for the MR integration with a delimiter separated
string, split based on the delimiter, and then recombine again using a comma separator. This
is problematic because the delimiter character may appear in a select expression, thus breaking
this logic. Instead, we should use a comma as the delimiter and avoid splitting and recombining
as it's not necessary in that case. Instead, the entire string can be used as-is in that case
to form the select expressions.

This message was sent by Atlassian JIRA

View raw message