phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2182) Pherf - Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold
Date Tue, 01 Sep 2015 20:54:46 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726170#comment-14726170
] 

ASF GitHub Bot commented on PHOENIX-2182:
-----------------------------------------

Github user codymarcel commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/115#discussion_r38470777
  
    --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java ---
    @@ -136,6 +142,8 @@ public Pherf(String[] args) throws Exception {
                     command.getOptionValue("writerThreadSize",
                             properties.getProperty("pherf.default.dataloader.threadpool"));
             properties.setProperty("pherf. default.dataloader.threadpool", writerThreadPoolSize);
    +        label = command.getOptionValue("label", null);
    +        compareResults = command.getOptionValue("compare", null);
    --- End diff --
    
    default to false instead of null


> Pherf - Add ability to compare of run(s) and generate warning if performance degrades
beyond set threshold
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2182
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2182
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Mujtaba Chohan
>            Assignee: Mujtaba Chohan
>         Attachments: PHOENIX-2182.patch
>
>
> Add ability to compare of run(s) and generate warning if performance degrades beyond
set threshold. This would also need that runs can be labeled for known baselines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message