phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2182) Pherf - Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold
Date Tue, 01 Sep 2015 21:45:45 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726256#comment-14726256
] 

ASF GitHub Bot commented on PHOENIX-2182:
-----------------------------------------

Github user codymarcel commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/115#discussion_r38476254
  
    --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResultsComparator.java
---
    @@ -0,0 +1,353 @@
    +package org.apache.phoenix.pherf.util;
    +
    +import java.io.FileNotFoundException;
    +import java.io.FileReader;
    +import java.io.PrintWriter;
    +import java.io.UnsupportedEncodingException;
    +import java.text.DecimalFormat;
    +import java.text.SimpleDateFormat;
    +import java.util.Date;
    +import java.util.LinkedHashMap;
    +import java.util.Map;
    +import java.util.TreeMap;
    +
    +import org.apache.commons.csv.CSVFormat;
    +import org.apache.commons.csv.CSVParser;
    +import org.apache.commons.csv.CSVRecord;
    +import org.apache.phoenix.pherf.PherfConstants;
    +import org.apache.phoenix.pherf.result.file.ResultFileDetails;
    +
    +/**
    + * Compare results based on set threshold and render results as Google Charts
    + */
    +public class ResultsComparator {
    +
    +	private String[] labels;
    +	private final Map<String, DataNode> datanodes = new TreeMap<String, DataNode>();
    +	private final PherfConstants constants = PherfConstants.create();
    +	private final String resultDir = constants.getProperty("pherf.default.results.dir");
    +	private final double threshold = Double.parseDouble(constants.getProperty("pherf.default.comparison.threshold"));
    +
    +	public ResultsComparator(String labels) {
    +		this.setLabelsAsString(labels);
    +	}
    +	
    +	String[] getLabels() {
    +		return labels;
    +	}
    +
    +	void setLabels(String[] labels) {
    +		this.labels = labels;
    +	}
    +
    +	void setLabelsAsString(String labels) {
    +		this.labels = labels.split(",");
    +	}
    +	
    +	public void readAndRender() {
    +		try {
    +			for (String label : labels) {
    +				read(label);
    +			}
    +			renderAsGoogleChartsHTML();
    +
    +		} catch (Exception e) {
    +			e.printStackTrace();
    +		}
    +	}
    +
    +	/**
    +	 * Reads aggregate file and convert it to DataNode 
    +	 * @param label
    +	 * @throws Exception
    +	 */
    +    private void read(String label) throws Exception {
    --- End diff --
    
    Can we use a CSVResultHandler with a ResultFileDetails.CSV_AGGREGATE_PERFORMANCE? It looks
like there is a fair amount of redundancy with that and the ResultWriter. It makes sense that
you need to wrap the compare logic into this, but result reading and writing should use the
existing framework for that.


> Pherf - Add ability to compare of run(s) and generate warning if performance degrades
beyond set threshold
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2182
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2182
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Mujtaba Chohan
>            Assignee: Mujtaba Chohan
>         Attachments: PHOENIX-2182.patch
>
>
> Add ability to compare of run(s) and generate warning if performance degrades beyond
set threshold. This would also need that runs can be labeled for known baselines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message