From dev-return-20423-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org Tue Sep 1 20:54:02 2015 Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87F5718813 for ; Tue, 1 Sep 2015 20:54:02 +0000 (UTC) Received: (qmail 51088 invoked by uid 500); 1 Sep 2015 20:54:02 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 51034 invoked by uid 500); 1 Sep 2015 20:54:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 51022 invoked by uid 99); 1 Sep 2015 20:54:02 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2015 20:54:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0178B182348 for ; Tue, 1 Sep 2015 20:54:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.795 X-Spam-Level: X-Spam-Status: No, score=0.795 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eWqkgdMD4OhQ for ; Tue, 1 Sep 2015 20:53:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 8FF9324A72 for ; Tue, 1 Sep 2015 20:53:48 +0000 (UTC) Received: (qmail 50442 invoked by uid 99); 1 Sep 2015 20:53:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2015 20:53:48 +0000 Date: Tue, 1 Sep 2015 20:53:48 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2182) Pherf - Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PHOENIX-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726168#comment-14726168 ] ASF GitHub Bot commented on PHOENIX-2182: ----------------------------------------- Github user codymarcel commented on a diff in the pull request: https://github.com/apache/phoenix/pull/115#discussion_r38470727 --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java --- @@ -76,6 +78,8 @@ options.addOption("d", "debug", false, "Put tool in debug mode"); options.addOption("stats", false, "Update Phoenix Statistics after data is loaded with -l argument"); + options.addOption("label", true, "Label a run. Result file name will be suffixed with specified label"); --- End diff -- Is this an override to then dynamically generated label? Also, it would be good if the label was applied as a column value in the result data. That way we can distinguish between runs on analysis. > Pherf - Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold > ---------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-2182 > URL: https://issues.apache.org/jira/browse/PHOENIX-2182 > Project: Phoenix > Issue Type: Improvement > Reporter: Mujtaba Chohan > Assignee: Mujtaba Chohan > Attachments: PHOENIX-2182.patch > > > Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold. This would also need that runs can be labeled for known baselines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)