[ https://issues.apache.org/jira/browse/PHOENIX-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726168#comment-14726168 ] 

ASF GitHub Bot commented on PHOENIX-2182:
-----------------------------------------

Github user codymarcel commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/115#discussion_r38470727
  
    --- Diff: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java ---
    @@ -76,6 +78,8 @@
             options.addOption("d", "debug", false, "Put tool in debug mode");
             options.addOption("stats", false,
                     "Update Phoenix Statistics after data is loaded with -l argument");
    +		options.addOption("label", true, "Label a run. Result file name will be suffixed with specified label");
    --- End diff --
    
    Is this an override to then dynamically generated label? Also, it would be good if the label was applied as a column value in the result data. That way we can distinguish between runs on analysis.


> Pherf - Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2182
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2182
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Mujtaba Chohan
>            Assignee: Mujtaba Chohan
>         Attachments: PHOENIX-2182.patch
>
>
> Add ability to compare of run(s) and generate warning if performance degrades beyond set threshold. This would also need that runs can be labeled for known baselines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)