phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmahonin <...@git.apache.org>
Subject [GitHub] phoenix pull request: PHOENIX-2464 Convert phoenix-spark module to...
Date Tue, 01 Dec 2015 02:50:06 GMT
Github user jmahonin commented on the pull request:

    https://github.com/apache/phoenix/pull/137#issuecomment-160831941
  
    Definitely closer, it does run now, but it takes about 4x longer to run than before. The
'doSetup' and 'doTeardown' used to be run only at the very beginning and at the very end,
and now they're being run before every test due to the '@Before' and '@After' annotations.
    
    I wonder if it's possible to do something like the 'ScalaClassRuleTest' in [1] and either
specify a '@BeforeAll' or an '@ClassRule' in a companion object and move the 'doSetup' and
'doTeardown' there?
    
    [1] http://randomallsorts.blogspot.ca/2012/11/junit-411-whats-new-rules.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message