phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2464) phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
Date Wed, 02 Dec 2015 01:37:10 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035085#comment-15035085
] 

ASF GitHub Bot commented on PHOENIX-2464:
-----------------------------------------

Github user gliptak commented on the pull request:

    https://github.com/apache/phoenix/pull/137#issuecomment-161151768
  
    Scala "static" methods on the companion object are not recognized as such by the ```@BeforeClass```
and ```@AfterClass``` annotations.


> phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-2464
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2464
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.6.0
>            Reporter: Josh Mahonin
>
> The existing phoenix-spark tests use the 'FunSuite' from ScalaTest, but in order to properly
inherit other JUnit annotations like '@ClassRules' from the base tests [1], it should be using
'JUnitSuite' instead.
> Issue exposed in PHOENX-2462
> [1] https://groups.google.com/forum/#!topic/scalatest-users/ayjVDbNiOas



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message