phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-2464) phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
Date Thu, 03 Dec 2015 04:42:10 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037244#comment-15037244
] 

ASF GitHub Bot commented on PHOENIX-2464:
-----------------------------------------

Github user jmahonin commented on the pull request:

    https://github.com/apache/phoenix/pull/137#issuecomment-161512711
  
    Thanks @gliptak for looking into this.
    
    I'll spend a bit of time seeing if I can work something out here. I think the main goal
is just to try be more compatible with JUnit annotations in inherited classes, but I do like
having these run as fast as possible as well.
    
    I don't think it's necessarily a major problem if we do nothing here either - the issue
only became apparent after merging in transaction support, a pretty large infrastructure addition,
which only took a few lines to work around with the existing tests.


> phoenix-spark module should use 'JUnitSuite' instead of 'FunSuite'
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-2464
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2464
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.6.0
>            Reporter: Josh Mahonin
>
> The existing phoenix-spark tests use the 'FunSuite' from ScalaTest, but in order to properly
inherit other JUnit annotations like '@ClassRules' from the base tests [1], it should be using
'JUnitSuite' instead.
> Issue exposed in PHOENX-2462
> [1] https://groups.google.com/forum/#!topic/scalatest-users/ayjVDbNiOas



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message